Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entities: add place #3456

Merged
merged 1 commit into from
Oct 3, 2023
Merged

entities: add place #3456

merged 1 commit into from
Oct 3, 2023

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Sep 6, 2023

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

@rerowep rerowep self-assigned this Sep 6, 2023
@github-actions github-actions bot added f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: data migration Data migration from a legacy system or a previous version labels Sep 6, 2023
@rerowep rerowep force-pushed the wep-place branch 2 times, most recently from d566477 to c90a9e7 Compare September 7, 2023 14:10
@github-actions github-actions bot removed f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: data migration Data migration from a legacy system or a previous version labels Sep 7, 2023
@github-actions github-actions bot added f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: data migration Data migration from a legacy system or a previous version labels Sep 12, 2023
@rerowep rerowep force-pushed the wep-place branch 6 times, most recently from aa44f0b to aecedf3 Compare September 14, 2023 08:28
@rerowep rerowep marked this pull request as ready for review September 14, 2023 08:28
@rerowep rerowep force-pushed the wep-place branch 2 times, most recently from 03694fb to 5bb68a2 Compare October 2, 2023 13:43
@rerowep
entities: add places
c04b2c2 
Co-Authored-by: Peter Weber <[email protected]>
jma
jma approved these changes Oct 3, 2023
View reviewed changes
tests/data/data.json Show resolved Hide resolved
@rerowep rerowep merged commit bedb8af into rero:staging Oct 3, 2023
3 checks passed
@rerowep rerowep deleted the wep-place branch October 3, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zannkukai zannkukai zannkukai approved these changes

@jma jma jma approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@PascalRepond PascalRepond Awaiting requested review from PascalRepond

@lauren-d lauren-d Awaiting requested review from lauren-d

Assignees

@rerowep rerowep

Labels
f: data migration Data migration from a legacy system or a previous version f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rerowep @Garfield-fr @jma @zannkukai